Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-skeleton-text usage missing #407

Closed
chrisgriffith opened this issue Feb 3, 2019 · 2 comments

Comments

Projects
None yet
3 participants
@chrisgriffith
Copy link
Contributor

commented Feb 3, 2019

It seems the usage pane is missing, along with a sample app.
https://ionicframework.com/docs/api/skeleton-text

@camwiegert

This comment has been minimized.

Copy link
Member

commented Feb 5, 2019

Looks like this happened because we have a usage example, but it's empty.

brandyscarney added a commit to ionic-team/ionic that referenced this issue Feb 27, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

I've added this as part of this PR: ionic-team/ionic#17612

Note that some of the usage examples will not work perfectly without my PR. 🙂

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this issue Mar 1, 2019

feat(skeleton-text): adds animated prop and support for CSS styling (i…
…onic-team#17612)

* moves most of the CSS to the host element so that it's easier to customize the skeleton text
* adds auto inherit for border-radius
* moves height to 100% so it will naturally fill an avatar and thumbnail
* adds animated property defaulted to `false`
* removes mode specific styles as they're the same
* changes background to an rgba making it easier to customize
* still works outside of a container element
* adds usage examples for javascript and angular
* moves the width to the parent element making it easier to style
* adds the ability to style the width using CSS
* uses the global theme text color as the background if a custom background is not supplied before defaulting

closes ionic-team/ionic-docs#407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.