Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jp): update translation/jp to v7 #2837

Merged
merged 320 commits into from
Apr 5, 2023
Merged

Conversation

rdlabo
Copy link
Collaborator

@rdlabo rdlabo commented Mar 21, 2023

This can be merged until Ionic 7 GA is available.

jaredcbaum and others added 30 commits September 19, 2022 22:04
* chore(docs pages): update favicons

* chore(docs pages meta): update 96x96 favicon
chore(): sync with main
this commit removes a '>' that doesn't appear to be used/needed
following an internal link
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
liamdebeasi and others added 2 commits March 28, 2023 11:50
# Conflicts:
#	docs/angular/lifecycle.md
#	docs/react/lifecycle.md
#	docs/vue/lifecycle.md
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there,

Thanks for all of the hard work translating the Ionic v7 documentation. We really appreciate it! As I understand it, this documentation was translated using DeepL with most of it reviewed by either you or another developer in the Ionic community.

According to #2837 (comment), not all of the translated content has been reviewed. Could we update this PR to only include the content that has been reviewed and approved by a person?

We'd like to start by merging only the reviewed content. As other content gets reviewed we are happy to accept those contributions in separate PRs. Please let me know if you have any questions.

@rdlabo
Copy link
Collaborator Author

rdlabo commented Mar 29, 2023

@liamdebeasi Now, all content has been reviewed and approved by me👍

a8df44b

rdlabo added 3 commits March 30, 2023 07:36
# Conflicts:
#	scripts/api.js
#	versioned_docs/version-v6/api/slide.md
#	versioned_docs/version-v6/api/slides.md
#	versioned_docs/version-v6/api/virtual-scroll.md
feat(v7): v7へのプルリクエスト
# Conflicts:
#	docs/api/accordion-group.md
#	docs/api/accordion.md
#	docs/api/action-sheet.md
#	docs/api/alert.md
#	docs/api/app.md
#	docs/api/avatar.md
#	docs/api/back-button.md
#	docs/api/backdrop.md
#	docs/api/badge.md
#	docs/api/breadcrumb.md
#	docs/api/breadcrumbs.md
#	docs/api/button.md
#	docs/api/buttons.md
#	docs/api/card-content.md
#	docs/api/card-header.md
#	docs/api/card-subtitle.md
#	docs/api/card-title.md
#	docs/api/card.md
#	docs/api/checkbox.md
#	docs/api/chip.md
#	docs/api/col.md
#	docs/api/content.md
#	docs/api/datetime.md
#	docs/api/fab-button.md
#	docs/api/fab-list.md
#	docs/api/fab.md
#	docs/api/footer.md
#	docs/api/grid.md
#	docs/api/header.md
#	docs/api/img.md
#	docs/api/infinite-scroll-content.md
#	docs/api/infinite-scroll.md
#	docs/api/input.md
#	docs/api/item-divider.md
#	docs/api/item-group.md
#	docs/api/item-option.md
#	docs/api/item-options.md
#	docs/api/item-sliding.md
#	docs/api/item.md
#	docs/api/label.md
#	docs/api/list-header.md
#	docs/api/list.md
#	docs/api/loading.md
#	docs/api/menu-button.md
#	docs/api/menu-toggle.md
#	docs/api/menu.md
#	docs/api/modal.md
#	docs/api/nav-link.md
#	docs/api/nav.md
#	docs/api/note.md
#	docs/api/picker.md
#	docs/api/popover.md
#	docs/api/progress-bar.md
#	docs/api/radio-group.md
#	docs/api/radio.md
#	docs/api/range.md
#	docs/api/refresher-content.md
#	docs/api/refresher.md
#	docs/api/reorder-group.md
#	docs/api/reorder.md
#	docs/api/ripple-effect.md
#	docs/api/route-redirect.md
#	docs/api/route.md
#	docs/api/router-link.md
#	docs/api/router-outlet.md
#	docs/api/router.md
#	docs/api/row.md
#	docs/api/searchbar.md
#	docs/api/segment-button.md
#	docs/api/segment.md
#	docs/api/select-option.md
#	docs/api/select.md
#	docs/api/skeleton-text.md
#	docs/api/slide.md
#	docs/api/spinner.md
#	docs/api/split-pane.md
#	docs/api/tab-bar.md
#	docs/api/tab-button.md
#	docs/api/tab.md
#	docs/api/tabs.md
#	docs/api/text.md
#	docs/api/textarea.md
#	docs/api/thumbnail.md
#	docs/api/title.md
#	docs/api/toast.md
#	docs/api/toggle.md
#	docs/api/toolbar.md
@rdlabo rdlabo requested a review from liamdebeasi April 5, 2023 00:54
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liamdebeasi liamdebeasi merged commit fe204b6 into translation/jp Apr 5, 2023
@liamdebeasi liamdebeasi deleted the translation/jp-v7 branch April 5, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.