-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Description
Prerequisites
- I have read the Contributing Guidelines.
- I agree to follow the Code of Conduct.
- I have searched for existing issues that already report this problem, without success.
Ionic Framework Version
v7.x
Current Behavior
In certain cases, a non-native IonRefresher gesture handler will get double-mounted (you can tell by stepping through code and seeing this.gesture
in refresher.ts is called twice in a row).
One of the mounts will have the incorrect .ion-content-scroll-host
setup and it causes the feed to refresh any time you try to scroll up.
Note: I realize the IonRefresher is being (ab)used, mounted then quickly unmounted and remounted, and there's a better way to do this where it will not cause a double-mounted gesture. However, I'm experiencing this issue in Voyager intermittently (see: aeharding/voyager#718). This reproduction is just the best way I can demonstrate this issue in a consistently reproducible manner.
Expected Behavior
Gestures should never be double mounted. .ion-content-scroll-host
should always be correctly connected.
Steps to Reproduce
- Clone reproduction
pnpm i
ionic serve
- Using an Android device, or Chrome simulator emulating an Android device, scroll down, then scroll up. See feed refresh.
Code Reproduction URL
https://github.com/aeharding/refresher-race
Ionic Info
Ionic:
Ionic CLI : 7.1.1 (/Users/aeharding/.nvm/versions/node/v20.8.1/lib/node_modules/@ionic/cli)
Ionic Framework : @ionic/react 7.5.1
Capacitor:
Capacitor CLI : 5.5.1
@capacitor/android : not installed
@capacitor/core : 5.5.1
@capacitor/ios : not installed
Utility:
cordova-res : not installed globally
native-run : not installed globally
System:
NodeJS : v20.8.1 (/Users/aeharding/.nvm/versions/node/v20.8.1/bin/node)
npm : 10.1.0
OS : macOS Unknown