-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Description
Type: bug
Platform: android 4.4 webview
This issue refers to a regression introduced with this commit from 19 Mar.
This is a new issue as desired by @perrygovier. Again (concerning above commit), what exactly do you mean by "Prevent gestures from breaking native scrolling"? Is there a use/test case? I could't find a related issue.
Here is a codepen that demonstrates the issue (try to drag the red box): http://codepen.io/MartinMa/pen/vOEmVR
Please confirm.
To get it up and running on your Android device, run the following commands using Ionic CLI.
ionic start dragtest http://codepen.io/MartinMa/pen/vOEmVR
cd dragtest
ionic platform add android
ionic run android
As already mentioned by @gregor-srdic, this issue also affects built-in events like on-hold
. (see issue 1729)
There is a work around. You have to pass {prevent_default_directions = ['left', 'up', 'right', 'down']}
as fourth argument to $ionicGesture.on
.
I think preventDefault();
should be the default, if 'overflow-scroll'
isn't present? With the current behavior it breaks drag gestures when using Ionic scroll - which is the default. So it's broken by default ;)