Skip to content

Conversation

ataraxus
Copy link
Contributor

Short description of what this resolves:

Better testability.

Changes proposed in this pull request:

  • add null check to prevent null dereference while testing with karma

Ionic Version: 2.x / 3.x

Fixes: #11185

@brandyscarney brandyscarney merged commit 8a4a93e into ionic-team:master May 19, 2017
@Mridul16
Copy link

where should i put the null check code? in test case or the component? Also if in the test case then where should i write it in the test case as i am not even able to create the page instance?.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants