feat(item-reorder): add side support #11642
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitMY
commented
May 12, 2017
src/components/item/item-reorder.ts
Outdated
| '[class.reorder-side-left]': 'side === "left"', | ||
| '[class.reorder-side-right]': 'side === "right"', | ||
| '[class.reorder-side-start]': 'side === "start"', | ||
| '[class.reorder-side-end]': 'side === "end"' |
There was a problem hiding this comment.
@manucorporat what would be the correct way here to add the classes? Should I can just use [ngClass] with a string.
# Conflicts: # src/components/item/item-reorder.scss # src/components/item/test/reorder/pages/root-page/root-page.html
manucorporat
suggested changes
Jun 15, 2017
| } | ||
|
|
||
| .reorder-side-start ion-reorder { | ||
| @include transform(translate3d(-160%, 0, 0)); |
There was a problem hiding this comment.
in other to prevent DRY, could we use a scss variable like $reorder-initial-transform ?
AmitMY
commented
Jun 15, 2017
src/components/item/item-reorder.ts
Outdated
| host: { | ||
| '[class.reorder-enabled]': '_enableReorder', | ||
| '[class.reorder-visible]': '_visibleReorder', | ||
| '[class.reorder-side-start]': 'side === "start"' |
There was a problem hiding this comment.
Change string comparison to boolean
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
A user needs this feature
Changes proposed in this pull request:
ion-itemOf course, this is RTL supported.
Ionic Version: 3.x
Fixes: #11637