Skip to content

Conversation

manucorporat
Copy link
Contributor

@manucorporat manucorporat commented Dec 7, 2018

  • No named buggy ion-router-outlet
  • Lazy loading works!
  • Simpler routes
  • Simpler markup
  • Beautiful URLS

Markup:

<ion-tabs>
  <ion-tab-bar>
    <ion-tab-button tab="account">
      <ion-label>Tab One</ion-label>
      <ion-icon name="add"></ion-icon>
    </ion-tab-button>

    <ion-tab-button tab="contact">
      <ion-label>Tab Two</ion-label>
      <ion-icon name="logo-ionic"></ion-icon>
    </ion-tab-button>
  </ion-tab-bar>
</ion-tabs>

Routes:

  {
    path: 'tabs',
    component: TabsComponent,
    children: [
      {
        path: 'account',
        children: [
          {
            path: 'nested/:id',
            component: TabsTab1NestedComponent
          },
          {
            path: '',
            component: TabsTab1Component
          }
        ]
      },
      {
        path: 'contact',
        children: [
          {
            path: 'one',
            component: TabsTab2Component
          },
          {
            path: '',
            redirectTo: 'one',
            pathMatch: 'full'
          }
        ]
      }
    ]
  }

@ionitron-bot ionitron-bot bot added package: angular @ionic/angular package package: core @ionic/core package labels Dec 7, 2018
@manucorporat manucorporat changed the title refactor(angular): lazy loading tabs [WIP] refactor(angular): lazy loading tabs Dec 7, 2018
@manucorporat manucorporat changed the title [WIP] refactor(angular): lazy loading tabs refactor(angular): lazy loading tabs Dec 7, 2018
@manucorporat
Copy link
Contributor Author

Fixes #16619

@manucorporat manucorporat force-pushed the feat-lazy-loading-tabs branch from 35b434c to 9c84f1f Compare December 8, 2018 11:34
@manucorporat manucorporat merged commit 437ad09 into master Dec 8, 2018
@manucorporat manucorporat deleted the feat-lazy-loading-tabs branch December 8, 2018 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant