Skip to content

Conversation

rodyhaddad
Copy link

You were missing karma-jasmine and karma-chrome-laucher from your package.json, making karma start ionic.conf.js throw errors.

It's probably installed globally on your machine, but it should still be listed in the devDependencies.

This PR adds them as devDependencies to the project :)

jasmine and chrome launcher, so 'npm install' fetches everything
mlynch added a commit that referenced this pull request Nov 21, 2013
add missing karma plugins to devDependencies in package.json
@mlynch mlynch merged commit 87c1f0f into ionic-team:master Nov 21, 2013
@mlynch
Copy link
Contributor

mlynch commented Nov 21, 2013

Thanks! Curious that travis-ci didn't freak out about that, I wonder if they had those packages also installed globally? Anyways, thanks for the PR 🐻

@rodyhaddad
Copy link
Author

After a bit of testing, I think I found why travis still passed:

I was using npm v1.1.x. After upgrading to v1.3.15, things worked even if karma-jasmine and karma-chrome-launcher weren't listed in the devDependencies

Running npm install in v1.3 would create almost the double amount of modules in node_modules/ then running the same thing in v1.1
Travis is running npm v1.2.32

So I guess the npm install algorithm changed from 1.1 to 1.2, making things like karma-requirejs (!) show up in node_modules/ even if it isn't a devDependency to the project (maybe a common sub-dependency? And so travis passed as a side-effect to a npm optimization)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants