Skip to content

feat(radio): add shadow parts #20952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 23, 2020
Merged

feat(radio): add shadow parts #20952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
07e7810
add shadow parts
liamdebeasi Apr 2, 2020
0102cd4
change icon-inner to mark
liamdebeasi Apr 22, 2020
490c679
change icon to container
liamdebeasi Apr 22, 2020
e91472a
Update core/src/components/radio/radio.tsx
liamdebeasi Apr 22, 2020
ffb4042
Merge remote-tracking branch 'origin/master' into radio-parts
liamdebeasi Apr 22, 2020
5b3c6bc
build
liamdebeasi Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions core/api.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -826,6 +826,8 @@ ion-radio,css-prop,--border-radius
ion-radio,css-prop,--color
ion-radio,css-prop,--color-checked
ion-radio,css-prop,--inner-border-radius
ion-radio,part,container
ion-radio,part,mark

ion-radio-group,none
ion-radio-group,prop,allowEmptySelection,boolean,false,false,false
Expand Down
7 changes: 5 additions & 2 deletions core/src/components/radio/radio.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ import { createColorClasses, hostContext } from '../../utils/theme';

/**
* @virtualProp {"ios" | "md"} mode - The mode determines which platform styles to use.
*
* @part container - The container for the radio mark.
* @part mark - The checkmark or dot used to indicate the checked state.
*/
@Component({
tag: 'ion-radio',
Expand Down Expand Up @@ -136,8 +139,8 @@ export class Radio implements ComponentInterface {
'radio-disabled': disabled,
}}
>
<div class="radio-icon">
<div class="radio-inner"/>
<div class="radio-icon" part="container">
<div class="radio-inner" part="mark" />
</div>
<button
type="button"
Expand Down
8 changes: 8 additions & 0 deletions core/src/components/radio/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,6 +137,14 @@ export const RadioExamples: React.FC = () => {
| `ionFocus` | Emitted when the radio button has focus. | `CustomEvent<void>` |


## Shadow Parts

| Part | Description |
| ------------- | -------------------------------------------------------- |
| `"container"` | The container for the radio mark. |
| `"mark"` | The checkmark or dot used to indicate the checked state. |


## CSS Custom Properties

| Name | Description |
Expand Down
29 changes: 27 additions & 2 deletions core/src/components/radio/test/basic/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,21 @@
<ion-radio id="dangerRadio" slot="end" color="danger" value="broccoli"></ion-radio>
</ion-item>
</ion-radio-group>

<ion-radio-group allow-empty-selection value="custom">
<ion-item>
<ion-label>Custom</ion-label>
<ion-radio slot="end" color="danger" value="custom" style="--border-radius:2px;--inner-border-radius: 10px 0px 10px 0px;"></ion-radio>
</ion-item>
</ion-radio-group>

<ion-radio-group allow-empty-selection value="custom">
<ion-item>
<ion-label>Radio ::part</ion-label>
<ion-radio slot="end" value="custom" class="radio-part"></ion-radio>
</ion-item>
</ion-radio-group>

<ion-item>
<ion-button slot="start" onClick="toggleBoolean('grapeChecked', 'checked')" fill="outline" size="small">Checked</ion-button>
<ion-button slot="start" onClick="toggleBoolean('grapeChecked', 'disabled')" fill="outline" size="small">Disabled</ion-button>
Expand Down Expand Up @@ -128,7 +135,7 @@
<span id="standAloneCheckedSpan"></span>
</p>


<ion-item>
<ion-label>Checkbox / Toggle</ion-label>
<ion-radio slot="start" id="checked"></ion-radio>
Expand Down Expand Up @@ -205,6 +212,24 @@
margin-top: -20px;
}

.radio-part::part(container) {
background: rgba(255, 0, 0, 0.3);
border-color: darkred;
}

.radio-part::part(mark) {
background: hotpink;
}

.radio-part.radio-checked::part(container) {
background: rgba(0, 255, 0, 0.3);
border-color: darkgreen;
}

.radio-part.radio-checked::part(mark) {
background: purple;
}

</style>

</ion-app>
Expand Down