Skip to content

Conversation

ugaya40
Copy link
Contributor

@ugaya40 ugaya40 commented Apr 10, 2020

Solve the problem that IonTabBar type does not have style attributes etc. in JSX.

closes #21006

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

In JSX, there is no style attribute etc for IonTabBar type.
Issue Number: #21006

What is the new behavior?

  • In JSX, style attribute etc are added to the IonTabBar type.

Does this introduce a breaking change?

  • Yes
  • No

Solve the problem that IonTabBar type does not have style attributes etc. in JSX.

closes #21006
@liamdebeasi liamdebeasi changed the title fix(IonTabBar): intersect ReactProps type to IonTabBar type fix(react): IonTabBar properly extends IonicReactProps Apr 10, 2020
@liamdebeasi liamdebeasi merged commit 102a842 into ionic-team:master Apr 10, 2020
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: IonTabBar does not have a style attribute in JSX.

2 participants