(fix): devs should create dist symlink for demos #2238
Conversation
When running gulp demos, the demos look for files like /dist/ionic-demo/nightly/ionic/css/ionic.min.css The current instructions direct devs to start their python server at /dist/ionic-demo/. This commit instructs devs to create a symlink to the parent directory so that the current build of ionic can be used in the demos.
|
Thanks for bringing this up @jimthedev. While this works, I'm inclined to update the demos so that the python server can be run from the root ionic folder like tests can. I'm not sure if this would break any of our automation though. @ajoslin, if it's safe to update the src paths in the demos, please assign this back. |
|
Yeah I agree that would be ideal. Didn't know about other tooling conflicts. If moving the test locations would be better then I will close this PR. Will leave open for now. |
|
Hey @jimthedev, I went ahead and updated the gulp task to generate the right links in the first place. Should be good now. Thanks for bringing it to our attention. |
|
Great! Thank you! On Mon, Sep 22, 2014 at 6:29 PM, Perry Govier notifications@github.com
|
3 participants
When running gulp demos, the demos look for files like /dist/ionic-demo/nightly/ionic/css/ionic.min.css
The current instructions direct devs to start their python server at /dist/ionic-demo/.
This commit instructs devs to create a symlink to the parent directory so that the current build of ionic can be used in the demos.