Skip to content

feat(menu): add console error for incorrect usage of contentId #23871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2021
Merged

feat(menu): add console error for incorrect usage of contentId #23871

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b7e1677
feat(menu): add console error for incorrect usage of contentId
willmartian Sep 2, 2021
01d34b4
Update core/src/components/menu/menu.tsx
willmartian Sep 7, 2021
2216e41
Update core/src/components/menu/menu.tsx
liamdebeasi Sep 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions core/src/components/menu/menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,6 +179,11 @@ AFTER:
console.error('Menu: must have a "content" element to listen for drag events on.');
return;
}

if (this.el.contains(content)) {
console.error(`Menu: "contentId" should refer to the main view's ion-content, not the ion-content inside of the ion-menu.`);
}

this.contentEl = content as HTMLElement;

// add menu's content classes
Expand Down