Skip to content

Conversation

nesk
Copy link

@nesk nesk commented Dec 13, 2014

While testing Ionic on an iPad Retina, my team (cc @jvelo @louisbeziau) and myself were surprised about the number of “missclicks” we noticed when clicking on elements with an ng-click directive. However, the buttons weren't affected by this behaviour.

After digging into Ionic's code, I found a solution. When you move too much your finger while tapping an element, the tap is cancelled, this is okay but the tolerance is way too low for any elements other than buttons. While buttons have a tolerance of 50px, other elements only have 6px. I increased this last value to 12px without noticing any strange behaviour with other Ionic's components and the missclick problems were solved.

One thing if you want to verify the improvement: this issue was especially encountered when we grazed the iPad.

Maybe this behaviour have been encountered on other devices but we only had an iPad to test this.

Improves tap behaviours on iPad by reducing “missclicks”
adamdbradley added a commit that referenced this pull request Dec 15, 2014
refactor(tap): increase tap release tolerance
@adamdbradley adamdbradley merged commit 894e429 into ionic-team:master Dec 15, 2014
@adamdbradley
Copy link
Contributor

This has been a difficult number to come up with, cross platform and for many different devices (slow and fast). 12px is the highest number i'm comfortable with right now as I don't want all list items to be clicked when they're scrolling or navigating through the app. We'll give this number a test and see how it goes. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants