Slightly increased the value of TAP_RELEASE_TOLERANCE constant #2715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing Ionic on an iPad Retina, my team (cc @jvelo @louisbeziau) and myself were surprised about the number of “missclicks” we noticed when clicking on elements with an
ng-click
directive. However, the buttons weren't affected by this behaviour.After digging into Ionic's code, I found a solution. When you move too much your finger while tapping an element, the tap is cancelled, this is okay but the tolerance is way too low for any elements other than buttons. While buttons have a tolerance of
50px
, other elements only have6px
. I increased this last value to12px
without noticing any strange behaviour with other Ionic's components and the missclick problems were solved.One thing if you want to verify the improvement: this issue was especially encountered when we grazed the iPad.
Maybe this behaviour have been encountered on other devices but we only had an iPad to test this.