Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Oct 20, 2023

aIssue number: resolves #28388


What is the current behavior?

We added a min-height: 56px to the input, textarea, and select components for MD mode. However, these were added for the outline/solid style inputs to align with the Material Design spec: https://material-components.github.io/material-components-web-catalog/#/component/text-field

They should not apply to regular inputs in an item. The end result is inconsistently sized items when used with non-control items.

What is the new behavior?

  • Non-filled and non-stacked/floating label controls are now have a minimum height of 44px.

There should be no changes to the following types of controls:

  1. iOS controls (all variants)
  2. MD filled controls
  3. MD stacked controls

Does this introduce a breaking change?

  • Yes
  • No

Other information

Dev build: 7.5.2-dev.11697818830.1a33c881

@github-actions github-actions bot added the package: core @ionic/core package label Oct 20, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review October 23, 2023 16:36
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@liamdebeasi liamdebeasi added this pull request to the merge queue Oct 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit b31ecbb Oct 26, 2023
@liamdebeasi liamdebeasi deleted the FW-5420 branch October 26, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core @ionic/core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: MD inconsistency: ion-item height is different with some children

3 participants