chore(dev-deps): upgrade to jest v29 #28412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwaskiewicz
force-pushed
the
rwaskiewicz/add-jest-29-support
branch
2 times, most recently
from
dfaf30c to
dbfbb0e
Compare
remove the top level dependency on `@jest/core`. this package is not directly used by the ionic framework. it is also brought into the project indirectly through existing (needed dependencies) `jest` and `jest-cli`.
this commit bumps the existing jest dependencies to v28 to begin to modernize our testing infrasturcture.
this commit bumps the existing jest dependencies to v29 to begin to modernize our testing infrasturcture.
rwaskiewicz
force-pushed
the
rwaskiewicz/add-jest-29-support
branch
from
dbfbb0e to
d2a3d4a
Compare
liamdebeasi
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #
What is the current behavior?
Ionic Framework uses Jest 27. Previously, this was due to a limitation of Stencil. As of Stencil v4.7.0, this limitation no longer exists & the Framework can upgrade to the latest version of Jest.
What is the new behavior?
There was a top level dependency on
@jest/corethat I could not find to be used anywhere. This dependency is included injestby default, and has been removed as a top level/package.jsondependency.Otherwise, all jest packages have been upgraded to jest v29. This is two major version bumps and a switch to the jest-circus runtime (instead of jest-jasmine2).
Does this introduce a breaking change?
Other information
There is some inherent risk of something breaking when someone like me who doesn't work on this project day-to-day bumps packages. I did this as a part of testing Jest 29 when implementing its support in Stencil and thought "Well, why not?". Feel free to reject this PR if you feel it's not worth the risk/effort at the moment.