fix(angular): inputs on standalone form controls are reactive #28434
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #28431
What is the current behavior?
My previous attempt at fixing #28358 caused inputs to no longer be correctly proxied to the underlying components. This was an attempt to work around an underlying ng-packagr bug (see linked thread for more info).
What is the new behavior?
I decided it would be best to continue using
ProxyCmp(since we know that works) and find an alternative to working around the ng-packagr bug. I spoke with the Angular team, and they recommended pulling the provider into its own object.forwardRefis now required since we are referencing the component before it is declared.ProxyCmpusage anymore.Does this introduce a breaking change?
Other information
Dev build:
7.5.3-dev.11698699090.1151d73fVerified that the issue is fixed with the repro provided in #28431
Also verified that this does not regress the issue described in #28358.