Skip to content

chore: packages do not explicitly run tsc #28450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 6, 2023
Merged

chore: packages do not explicitly run tsc #28450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4dd0692
refactor(vue): use ts rollup plugin
liamdebeasi Nov 1, 2023
266cebd
refactor(vue-router): use ts rollup plugin
liamdebeasi Nov 1, 2023
9721d3d
refactor(react): use ts rollup plugin
liamdebeasi Nov 1, 2023
5ac163e
refactor(react-router): use ts rollup plugin
liamdebeasi Nov 1, 2023
1175b25
remove line
liamdebeasi Nov 1, 2023
36aed8c
typo
liamdebeasi Nov 1, 2023
d1507fb
Merge branch 'main' into rollup-ts
liamdebeasi Nov 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 96 additions & 0 deletions packages/react-router/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions packages/react-router/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@
},
"scripts": {
"build": "npm run clean && npm run compile",
"clean": "rimraf dist dist-transpiled",
"compile": "npm run tsc && rollup -c",
"clean": "rimraf dist",
"compile": "rollup -c",
"eslint": "eslint src",
"prettier": "prettier \"./src/**/*.{html,ts,tsx,js,jsx}\"",
"lint": "npm run eslint && npm run prettier -- --write --cache",
"lint.fix": "npm run eslint -- --fix && npm run prettier -- --write --cache",
"tsc": "tsc -p .",
"sync": "sh ./scripts/sync.sh"
},
"main": "dist/index.js",
Expand All @@ -49,6 +48,7 @@
"@ionic/eslint-config": "^0.3.0",
"@ionic/prettier-config": "^2.0.0",
"@rollup/plugin-node-resolve": "^8.1.0",
"@rollup/plugin-typescript": "^11.1.5",
"@types/node": "^14.0.14",
"@types/react": "16.14.0",
"@types/react-dom": "^16.9.0",
Expand Down
9 changes: 7 additions & 2 deletions packages/react-router/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import sourcemaps from 'rollup-plugin-sourcemaps';
import resolve from '@rollup/plugin-node-resolve';
import typescript from '@rollup/plugin-typescript';

export default {
input: 'dist-transpiled/index.js',
input: 'src/index.ts',
output: [
{
file: 'dist/index.js',
Expand All @@ -11,5 +12,9 @@ export default {
}
],
external: (id) => !/^(\.|\/)/.test(id),
plugins: [resolve(), sourcemaps()],
plugins: [
typescript(),
resolve(),
sourcemaps()
],
};
2 changes: 1 addition & 1 deletion packages/react-router/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"outDir": "dist-transpiled",
"outDir": "dist",
"declarationDir": "dist/types",
"removeComments": false,
"inlineSources": true,
Expand Down
105 changes: 102 additions & 3 deletions packages/react/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 3 additions & 4 deletions packages/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,12 @@
},
"scripts": {
"build": "npm run clean && npm run copy && npm run compile",
"clean": "rimraf dist && rimraf dist-transpiled && rimraf routing",
"compile": "npm run tsc && rollup -c",
"clean": "rimraf dist && rimraf routing",
"compile": "rollup -c",
"eslint": "eslint src",
"prettier": "prettier \"./src/**/*.{html,ts,tsx,js,jsx}\"",
"lint": "npm run eslint && npm run prettier -- --write --cache",
"lint.fix": "npm run eslint -- --fix && npm run prettier -- --write --cache",
"tsc": "tsc -p .",
"copy": "node scripts/copy.js",
"test.spec": "jest --ci",
"test.treeshake": "node scripts/treeshaking.js dist/index.esm.js",
Expand All @@ -52,6 +51,7 @@
"@ionic/eslint-config": "^0.3.0",
"@ionic/prettier-config": "^2.0.0",
"@rollup/plugin-node-resolve": "^8.1.0",
"@rollup/plugin-typescript": "^11.1.5",
"@rollup/plugin-virtual": "^2.0.3",
"@testing-library/jest-dom": "^5.11.6",
"@testing-library/react": "^11.2.2",
Expand Down Expand Up @@ -83,7 +83,6 @@
"testPathIgnorePatterns": [
"cypress",
"node_modules",
"dist-transpiled",
"dist",
"test/base/*",
"test/apps/*",
Expand Down
9 changes: 3 additions & 6 deletions packages/react/rollup.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import resolve from '@rollup/plugin-node-resolve';
import sourcemaps from 'rollup-plugin-sourcemaps';
// import json from '@rollup/plugin-json';
import typescript from '@rollup/plugin-typescript';

export default {
input: {
index: 'dist-transpiled/index',
// 'routing/index': 'dist-transpiled/routing/index'
},
input: 'src/index.ts',
output: [
{
dir: 'dist/',
Expand All @@ -18,8 +15,8 @@ export default {
],
external: (id) => !/^(\.|\/)/.test(id),
plugins: [
typescript(),
resolve(),
sourcemaps(),
// json()
],
};
2 changes: 1 addition & 1 deletion packages/react/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"noImplicitReturns": true,
"noUnusedLocals": true,
"noUnusedParameters": true,
"outDir": "dist-transpiled",
"outDir": "dist",
"declarationDir": "dist/types",
"removeComments": false,
"inlineSources": true,
Expand Down
Loading