Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 1, 2023

Issue number: N/A


What is the current behavior?

These scripts are old and do not do anything (np isn't even a dependency).

What is the new behavior?

  • Removed the scripts from react and react-router

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added the package: react @ionic/react package label Nov 1, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review November 1, 2023 19:53
@liamdebeasi liamdebeasi enabled auto-merge November 1, 2023 19:53
@liamdebeasi liamdebeasi added this pull request to the merge queue Nov 1, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Nov 1, 2023
Merged via the queue into main with commit b7d1a5c Nov 1, 2023
@liamdebeasi liamdebeasi deleted the remove-script branch November 1, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: react @ionic/react package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants