Skip to content

refactor: update to rollup 4 #28459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Nov 7, 2023
Merged

refactor: update to rollup 4 #28459

merged 16 commits into from
Nov 7, 2023

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Nov 2, 2023 •
edited
Loading

Issue number: N/A

What is the current behavior?

The vue, vue-router, react, and react-router packages are bundled with a version of rollup that are 2 major versions out of date.

What is the new behavior?

  • Update deps to rollup 4 and made any necessary changes as a result of breaking changes
  • Removed the react projects old treeshaking script. The rollup dep used was incompatible with Rollup 4, and the script didn't work to begin with.
  • Removed the source maps and resolve plugins. These did not make any difference in the final result, and source maps are still included in the final build.
  • Removed a PURE annotation from an import. Rollup 4 warns about this, and this PURE annotation does not seem to be needed since every import in this file uses "createReactComponent" to begin with.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@github-actions github-actions bot added package: vue @ionic/vue package package: react @ionic/react package labels Nov 2, 2023
@liamdebeasi liamdebeasi changed the title Rollup 4 refactor: update to rollup 4 Nov 2, 2023
@liamdebeasi liamdebeasi marked this pull request as ready for review November 2, 2023 21:00
Base automatically changed from rollup-ts to main November 6, 2023 19:42
thetaPC
thetaPC approved these changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liamdebeasi liamdebeasi enabled auto-merge November 6, 2023 22:51
@liamdebeasi liamdebeasi added this pull request to the merge queue Nov 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Nov 7, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 7, 2023
@liamdebeasi liamdebeasi added this pull request to the merge queue Nov 7, 2023
Merged via the queue into main with commit dfaa006 Nov 7, 2023
@liamdebeasi liamdebeasi deleted the rollup-4 branch November 7, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thetaPC thetaPC thetaPC approved these changes

@averyjohnston averyjohnston Awaiting requested review from averyjohnston

Assignees

No one assigned

Labels

package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@liamdebeasi @thetaPC