refactor(angular): animation controller uses correct core instance #28473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-perkins
changed the title
sean-perkins
force-pushed
the
sp/FW-5484
branch
from
c7d4290 to
2d18148
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The
AnimationControllerdoes not use the correct underlying instance of the utilities from either the lazy or custom elements build, depending on if the developer is using@ionic/angularor@ionic/angular/standalone. It will always use the lazy instance.What is the new behavior?
AnimationControlleruses the instance of the utilities based on it's implementation type, e.g.@ionic/angular/standaloneuses the custom elements build with the utilities from@ionic/core/components.@ionic/angularand@ionic/angular/standalonenow export their own specific implementation ofAnimationControllerDoes this introduce a breaking change?
Ionic was re-exporting the
AnimationControllerfrom both@ionic/angularand@ionic/angular/standaloneentry points. Developers will not need to update their implementations or change import paths to take advantage of this change.Other information