Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/angular/common/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export { ActionSheetController } from './providers/action-sheet-controller';
export { AlertController } from './providers/alert-controller';
export { LoadingController } from './providers/loading-controller';
export { MenuController } from './providers/menu-controller';
Expand Down Expand Up @@ -39,5 +38,6 @@ export * from './directives/control-value-accessors';
export { ProxyCmp } from './utils/proxy';

export { IonicRouteStrategy } from './utils/routing';
export { OverlayBaseController } from './utils/overlay';

export { raf } from './utils/util';
2 changes: 1 addition & 1 deletion packages/angular/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export * from './directives/validators';

// PROVIDERS
export {
ActionSheetController,
AlertController,
LoadingController,
ModalController,
Expand All @@ -42,6 +41,7 @@ export {
ViewDidLeave,
} from '@ionic/angular/common';
export { MenuController } from './providers/menu-controller';
export { ActionSheetController } from './providers/action-sheet-controller';

// PACKAGE MODULE
export { IonicModule } from './ionic-module';
Expand Down
13 changes: 13 additions & 0 deletions packages/angular/src/providers/action-sheet-controller.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
import { Injectable } from '@angular/core';
import { OverlayBaseController } from '@ionic/angular/common';
import type { ActionSheetOptions } from '@ionic/core';
import { actionSheetController } from '@ionic/core';

@Injectable({
providedIn: 'root',
})
export class ActionSheetController extends OverlayBaseController<ActionSheetOptions, HTMLIonActionSheetElement> {
constructor() {
super(actionSheetController);
}
}
2 changes: 1 addition & 1 deletion packages/angular/standalone/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ export { IonRouterLink, IonRouterLinkWithHref } from './navigation/router-link-d
export { IonTabs } from './navigation/tabs';
export { provideIonicAngular } from './providers/ionic-angular';
export { MenuController } from './providers/menu-controller';
export { ActionSheetController } from './providers/action-sheet-controller';
export {
ActionSheetController,
AlertController,
LoadingController,
ModalController,
Expand Down
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import { Injectable } from '@angular/core';
import { OverlayBaseController } from '@ionic/angular/common';
import type { ActionSheetOptions } from '@ionic/core/components';
import { actionSheetController } from '@ionic/core/components';

import { OverlayBaseController } from '../utils/overlay';

@Injectable({
providedIn: 'root',
})
Expand Down
6 changes: 6 additions & 0 deletions packages/angular/test/base/e2e/src/lazy/providers.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -33,5 +33,11 @@ describe('Providers', () => {
cy.get('#set-menu-count').click();
cy.get('#registered-menu-count').should('have.text', '1');
});

it('should open an action sheet', () => {
cy.get('button#open-action-sheet').click();

cy.get('ion-action-sheet').should('be.visible');
});
});

Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
describe('Action Sheet Controller', () => {
beforeEach(() => {
cy.visit('/standalone/action-sheet-controller');
})

it('should open an action sheet', () => {
cy.get('button#open-action-sheet').click();

cy.get('ion-action-sheet').should('be.visible');
});
})
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,5 @@
</p>

<button id="set-menu-count" (click)="setMenuCount()">Set Menu Count</button>
<button id="open-action-sheet" (click)="openActionSheet()">Open Action Sheet</button>
</ion-content>
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export class ProvidersComponent {
registeredMenuCount = 0;

constructor(
actionSheetCtrl: ActionSheetController,
private actionSheetCtrl: ActionSheetController,
alertCtrl: AlertController,
loadingCtrl: LoadingController,
private menuCtrl: MenuController,
Expand Down Expand Up @@ -88,4 +88,12 @@ export class ProvidersComponent {
const menus = await this.menuCtrl.getMenus();
this.registeredMenuCount = menus.length;
}

async openActionSheet() {
const actionSheet = await this.actionSheetCtrl.create({
buttons: ['Button']
});

await actionSheet.present();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<ul id="content">
<button id="open-action-sheet" (click)="openActionSheet()">Open Action Sheets</button>
</ul>

Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { Component } from '@angular/core';
import { ActionSheetController } from '@ionic/angular/standalone';

@Component({
selector: 'app-action-sheet-controller',
templateUrl: './action-sheet-controller.component.html',
standalone: true
})
export class ActionSheetControllerComponent {
registeredMenuCount = 0;

constructor(private actionSheetCtrl: ActionSheetController) {}

async openActionSheet() {
const actionSheet = await this.actionSheetCtrl.create({
buttons: ['Button']
});

await actionSheet.present();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ export const routes: Routes = [
component: AppComponent,
children: [
{ path: 'menu-controller', loadComponent: () => import('../menu-controller/menu-controller.component').then(c => c.MenuControllerComponent) },
{ path: 'action-sheet-controller', loadComponent: () => import('../action-sheet-controller/action-sheet-controller.component').then(c => c.ActionSheetControllerComponent) },
{ path: 'popover', loadComponent: () => import('../popover/popover.component').then(c => c.PopoverComponent) },
{ path: 'modal', loadComponent: () => import('../modal/modal.component').then(c => c.ModalComponent) },
{ path: 'router-outlet', loadComponent: () => import('../router-outlet/router-outlet.component').then(c => c.RouterOutletComponent) },
Expand Down