refactor(angular): gesture controller uses correct core instance #28477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thetaPC which tests would you suggest here? The custom code that is specific to the Angular implementation is: https://github.com/ionic-team/ionic-framework/pull/28477/files#diff-bed6d361bb9f4f8db3c7f80b9ded377fc71817a99a84f1172b40a4c497bbf1e4R14-R21, but would be better suited with an unit test vs. e2e test - validating that gesture callbacks are ran through a zone. We do not currently have any test infrastructure for unit tests in the angular test apps. |
|
@sean-perkins if we can setup the test apps with unit tests in the future then we should add the test that you suggested. For now, we can not leave it as is. |
sean-perkins
force-pushed
the
sp/FW-5485
branch
from
f4c6b37 to
401b144
Compare
sean-perkins
force-pushed
the
sp/FW-5485
branch
from
401b144 to
6c7d0bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: Internal
What is the current behavior?
The
GestureControllerprovider does not use the correct underlying instance of the utilities from either the lazy or custom elements build, depending on if the developer is using@ionic/angularor@ionic/angular/standalone. It will always use the lazy instance.This applied to the
createGesturefunction.What is the new behavior?
GestureControlleruses the instance of the utilities based on it's implementation type, e.g.@ionic/angular/standaloneuses the custom elements build with the utilities from@ionic/core/components.@ionic/angularand@ionic/angular/standalonenow export their own specific implementation ofGestureControllerDoes this introduce a breaking change?
Other information