fix(picker): keyboard entry works with options #28652
Conversation
| const findItemFromCompleteValue = values.find(({ text }) => { | ||
| const parsedText = text.replace(/^0+(?=[1-9])|0+(?=0$)/, ''); | ||
| const findItemFromCompleteValue = options.find(({ textContent }) => { | ||
| const parsedText = textContent!.replace(/^0+(?=[1-9])|0+(?=0$)/, ''); |
There was a problem hiding this comment.
Keyboard entry is currently only used inside of Datetime where we guarantee textContent is set. If we end up exposing this feature publicly we should revisit this assumption.
There was a problem hiding this comment.
Could we move this to a comment directly in the code?
There was a problem hiding this comment.
Added in a00f563
liamdebeasi
requested review from
a team,
sean-perkins and
thetaPC
as code owners
| const findItemFromCompleteValue = values.find(({ text }) => { | ||
| const parsedText = text.replace(/^0+(?=[1-9])|0+(?=0$)/, ''); | ||
| const findItemFromCompleteValue = options.find(({ textContent }) => { | ||
| const parsedText = textContent!.replace(/^0+(?=[1-9])|0+(?=0$)/, ''); |
There was a problem hiding this comment.
Could we move this to a comment directly in the code?
|
@liamdebeasi any idea when this update will be released? im not seeing keyboard navigation working for standalone ion-picker in v7.8.1 |
|
@mlakmal This fix can be found in v8 beta! If you want to test it out, then it's recommended to read the upgrade guide to v8 beta on the Frameworks docs site. |
Thanks for the info. But we have a hard dependency with angular 15. Are thr any plans to fix this in v7 ? |
|
We don't plan to backport this feature to |
6 participants
Issue number: N/A
What is the current behavior?
As noted in #28622, keyboard entry was not migrated to minimize the amount of code changes that needed to be reviewed at once. Keyboard entry would be updated in a separate PR.
What is the new behavior?
ion-picker-column-optionelements in a picker column instead of theitemproperty on the column.Does this introduce a breaking change?
Other information