chore(alert): remove ion-buttons from tests #28823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
suggested changes
Jan 15, 2024
Comment on lines
30
to
33
| <button expand="block" class="blue" onclick="presentAlert()">Alert</button> | ||
| <button expand="block" class="light-blue" onclick="presentAlertLongMessage()">Alert Long Message</button> | ||
| <button expand="block" class="red" onclick="presentAlertMultipleButtons()">Multiple Buttons (>2)</button> | ||
| <button expand="block" class="light" onclick="presentAlertNoMessage()">Alert No Message</button> |
There was a problem hiding this comment.
expand="block" is an ion-button API, so it should be removed if we are going to use button elements. (Same for all other instances of this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
ion-buttonis being used as a way to open the alerts. It's not being used to test functionality.When
ion-buttonis updated then the screenshots in the alert tests must be updated. This shouldn't happen whenion-buttonisn't necessary to have in these tests.What is the new behavior?
ion-buttonwithbuttonDoes this introduce a breaking change?
Other information
N/A