Skip to content

Conversation

thetaPC
Copy link
Contributor

@thetaPC thetaPC commented Jan 31, 2024

Issue number: N/A


What is the current behavior?

The packages, Angular, React, and Vue, will accept any app_dir parameter when passing it to the build script. This can lead to a user to entering a directory that doesn't exist within test/apps. If this happens, then the build folder will include an incomplete test app.

For example:

  1. ./build ng13
  2. This creates a build/ng13 folder, but the folder only contains the contents from the base folder. This causes it to be incomplete.

What is the new behavior?

  • Provides a message that the provided app directory doesn't exist.
  • Does not create the incomplete app when an invalid app directory is given.

Does this introduce a breaking change?

  • Yes
  • No

Other information

N/A

@github-actions github-actions bot added package: angular @ionic/angular package package: vue @ionic/vue package package: react @ionic/react package labels Jan 31, 2024
@thetaPC thetaPC marked this pull request as ready for review January 31, 2024 23:12
Copy link
Contributor

@averyjohnston averyjohnston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and works great, thank you!

@thetaPC thetaPC added this pull request to the merge queue Feb 1, 2024
Merged via the queue into main with commit 51c729e Feb 1, 2024
@thetaPC thetaPC deleted the packags-test-build branch February 1, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: react @ionic/react package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants