test(radio): remove legacy tests #29016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liamdebeasi
requested review from
averyjohnston and
brandyscarney
as code owners
averyjohnston
suggested changes
Feb 12, 2024
Comment on lines
88
to
94
| <ion-item> | ||
| <ion-radio aria-label="Radio" disabled slot="start"></ion-radio> | ||
| <ion-input aria-label="Input" placeholder="Disabled Radio w/ Input"></ion-input> | ||
| <ion-input aria-label="Input" placeholder="Input"></ion-input> | ||
| </ion-item> | ||
|
|
||
| <ion-item> | ||
| <ion-radio aria-label="Radio" disabled slot="end"></ion-radio> | ||
| <ion-input aria-label="Input" placeholder="Disabled Radio w/ Input"></ion-input> | ||
| <ion-input aria-label="Input" placeholder="Input"></ion-input> | ||
| </ion-item> |
There was a problem hiding this comment.
These two items are now exactly the same. This category is checking multiple different inputs in the same item, one of which is disabled and the other isn't, which is lost now that the radios are removed. If we don't think that check is still useful, we should remove the items entirely.
There was a problem hiding this comment.
Brandy is removing the input usage in #29017
| <ion-item> | ||
| <ion-radio disabled slot="start" legacy="true"></ion-radio> | ||
| <ion-input placeholder="Disabled Radio w/ Input" legacy="true"></ion-input> | ||
| <ion-input placeholder="Input" legacy="true"></ion-input> |
There was a problem hiding this comment.
Same comments here as in item/test/disabled above.
There was a problem hiding this comment.
Same comment as #29016 (comment)
averyjohnston
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the tests for the legacy radio syntax. A separate PR will be used to remove the implementation for the legacy syntax.