Skip to content

Conversation

liamdebeasi
Copy link
Contributor

@liamdebeasi liamdebeasi commented Feb 13, 2024

This pull request includes the changes to remove the legacy property for the range as part of #29040. That pull request specifically focuses on updating tests to remove any legacy range usage. The internal ticket suggested separating these changes into individual pull requests. Please refer to the mentioned pull request for a detailed description of the combined changes from both pull requests. This will be merged into that pull request upon approval.

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Feb 13, 2024
@liamdebeasi liamdebeasi changed the title 2997 impl refactor(range): remove legacy syntax Feb 13, 2024
@liamdebeasi
Copy link
Contributor Author

I made a few test adjustments in 8d89c1f that I missed when originally removing the legacy range tests.

@liamdebeasi liamdebeasi marked this pull request as ready for review February 14, 2024 00:31
@liamdebeasi liamdebeasi requested review from a team, sean-perkins and thetaPC as code owners February 14, 2024 00:31
Copy link
Contributor

@mapsandapps mapsandapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks correct ✅

@liamdebeasi liamdebeasi merged commit 735fa88 into FW-2997 Feb 14, 2024
@liamdebeasi liamdebeasi deleted the 2997-impl branch February 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants