-
Notifications
You must be signed in to change notification settings - Fork 13.4k
chore(github-actions): use flexible options to update screenshots #29044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the update screenshots action with the following inputs:
- ✅
badge
- Runs:npx playwright test src/components/badge
- ❌
src/components/badge/test/basic
- Runs:npx playwright test src/components/src/components/badge/test/basic
- ✅
badge tabs
- Runs:npx playwright test src/components/badge src/components/tabs
- ✅
unknown
- Runs:npx playwright test src/components/unknown
- ✅ blank - Runs:
npx playwright test
The only one that didn't work as expected is the 2nd one. It appended the entire path onto src/components
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running the update screenshots action with latest results in the following:
- ✅
badge
- Runs:npx playwright test badge
- ✅
src/components/badge/test/basic
- Runs:npx playwright test src/components/badge/test/basic
- ✅
badge tabs
- Runs:npx playwright test badge tabs
- ✅
unknown
- Runs:npx playwright test unknown
- ✅ blank - Runs:
npx playwright test
Looks good to me! 👍 Let me know if you need me to test it after the Docker update is merged in, but I don't think it should be affected.
@brandyscarney just to be safe, let's test it with the docker changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works with Docker 👍
Issue number: N/A
What is the current behavior?
GitHub actions allow screenshots to be updated either by updating all the components or providing a component name.
If a component name is given, then the screenshots will only be updated on
src/components/{component-name}
. This isn't ideal when wanting to update a specific path.What is the new behavior?
ion-
. The developer needs to submit a valid component name or valid path.src/components/
Does this introduce a breaking change?
Other information
How to test:
Recommended to test:
chip
)src/components/chip/test/a11y
)random-component
)