Skip to content

Conversation

sloops77
Copy link

This adds support for recognising trigger.io apps as WebView not a browser. To make this work at the moment the user needs to add this in a angular.run block:

window.addEventListener("load", function() {
  if (!!window.forge) {
    ionic.trigger('deviceready', {
      target: document
    });
  }
});

Reopens this PR cleaned off blurAll removal: #2667

@perrygovier perrygovier added this to the 1.0.0-rc2 milestone Mar 24, 2015
@perrygovier perrygovier self-assigned this Mar 24, 2015
perrygovier added a commit that referenced this pull request Mar 27, 2015
feat(platform): recognize trigger.io as a webView platform
@perrygovier perrygovier merged commit f766ff4 into ionic-team:master Mar 27, 2015
@francisosih
Copy link

Hello @sloops77 I tried your suggestion and I haven't been able to make it work.

@sloops77
Copy link
Author

Hi Francis, check the forum for my reply

@sloops77
Copy link
Author

Perry,

thanks for merging. It would be good to integrate the fake 'deviceready' event code into master so people dont need to discover this issue to figure out why "it isn't working". Would you suggest adding it to platform.js directly, or would it be better to have a separate triggerio.js file in utils? The benefit of the latter is that any adapter code or phonegap event triggering can be encapsulated there.

I suppose i just convinced my help, but if i could get your ok then i'll send in the next PR this week.

@francisosih
Copy link

I would suggest adding it straight into the triggerio.js, thanks mate!

Francis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants