Allows a view to update the navbar title if his title changes #501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a watch to see if the contents of the view title changes and, if so, fire an event to notify the navbar and update the title.
Added support for TabBar icon badges using the attribute badge in the tab directive. Ex: <tab icon-on="icon ion-ios7-person" icon-off="icon ion-ios7-person-outline" href="#/tab/myprofile" badge="3"> I’ve used the colors of the TabBar itself but inverted for the badge. I don’t know if you’ll want to merge this straight on but I think it can help as a start point for this feature. I’ve tried to do it as integrated as possible.
This reverts commit 1bd89a8.
|
Sorry for the revert, i've messed it up commiting to the main branch… |
|
👍 |
somethingnew2-0
added a commit
that referenced
this pull request
Feb 1, 2014
Allows a view to update the navbar title if his title changes
|
Thanks! |
|
To you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a watch to see if the contents of the view title changes and, if so, fire an event to notify the navbar and update the title.
I've realized that if I want to update the view title with data from an async request it doesn't update. So, after searching the forums, I've tried to patch it myself. Is there a better way to do this? If not, consider my pull request.
Thanks for your time.