fix(loader): make the loader service return a promise instead of the … #6488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deprecated object, update docum make the loader service return a promise instead of the deprecated object, update documents to show proper usage #3717
| * $ionicLoading.show({ | ||
| * template: 'Loading...' | ||
| * }).then(function(){ | ||
| * console.log("The loading indicator is now displayed"); |
There was a problem hiding this comment.
@danbucholtz I really don't think the console.log outputs should be there.
There was a problem hiding this comment.
That is just the documentation on how to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Changes proposed in this pull request:
Ionic Version: 1.x / 2.x
Fixes: #
…deprecated object, update docum
make the loader service return a promise instead of the deprecated object, update documents to show
proper usage
#3717