Skip to content

Conversation

@jbagaresgaray
Copy link
Contributor

add new methods to matching the last update of the cordova plugin "cordova-plugin-preview-any-file"

@mostafa-mansour1
Copy link
Contributor

I already have a pull request to update thee wrap from 2nd Feb

#3612

but still didn't merge till now

@mostafa-mansour1
Copy link
Contributor

in the section of the install guide
https://github.com/mostafa-mansour1/previewAnyFile

I add the wrapper as a zip file until it merged here

@jbagaresgaray
Copy link
Contributor Author

I already have a pull request to update thee wrap from 2nd Feb

#3612

but still didn't merge till now

Ohh I see.... you're implementation is base on Observables... Let's wait until Ionic Team gives there feedback... :(

@danielsogl danielsogl merged commit b8de7f0 into danielsogl:master Apr 5, 2021
@mostafa-mansour1
Copy link
Contributor

oops, this pull request has been approved and the original one conflict with it, what we should do to resolve it, I already wrote the documentation based on observables

@mostafa-mansour1
Copy link
Contributor

can i revert the changes to add my code and documentation?

@jbagaresgaray
Copy link
Contributor Author

@mostafa-mansour1 I think Ionic accepts base on Promise response as most of the plugins returns promise as well.. consult @danielsogl instead...

@mostafa-mansour1
Copy link
Contributor

ok no problem, but we need at least to fix the docs,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants