Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(slides): add effect plugins for swiper #16616
@brandyscarney I noticed we already have swiper as a dependency on our
Do we need this additional swiper.js file?
Remember that you have a new version:
referenced this pull request
Apr 4, 2019
After some discussion with the team, we have decided to go a different route with the swiper animation plugins. Instead of adding the additional animations directly into the framework, we have decided to expose the event handlers that swiper provides. This has a few benefits:
I have created a PR for this here: #17959 which will be merged instead of this PR. Any feedback on this PR would be greatly appreciated!
Thank you very much for your contributions here, we really appreciate it! You will be added as a co-contributor to #17959.