Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(icon): remove <title> during build step #1169

Merged
merged 2 commits into from
Jan 18, 2023
Merged

fix(icon): remove <title> during build step #1169

merged 2 commits into from
Jan 18, 2023

Conversation

jonz94
Copy link
Contributor

@jonz94 jonz94 commented Jan 17, 2023

Close #1168

@liamdebeasi liamdebeasi self-requested a review January 18, 2023 13:35
@liamdebeasi liamdebeasi changed the title fix(script): do not add default <title> fix(icon): remove <title> during build step Jan 18, 2023
liamdebeasi
liamdebeasi approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@liamdebeasi liamdebeasi mentioned this pull request Jan 18, 2023
Closed
@liamdebeasi liamdebeasi merged commit 93b4fa4 into ionic-team:main Jan 18, 2023
@liamdebeasi
Copy link
Contributor

Merged. Thank you!

@jonz94 jonz94 deleted the fix-build-script branch January 19, 2023 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamdebeasi liamdebeasi liamdebeasi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: <title> tag still exists in svg icon (ionicons 6.1.0)
2 participants
@jonz94 @liamdebeasi