fix(dev-server): fix error logging when build aborted

Author: adamdbradley

src/compiler/build/build-finish.ts

@@ -56,21 +56,19 @@ export async function buildFinish(config: d.Config, compilerCtx: d.CompilerCtx,
       compilerCtx.hasSuccessfulBuild = true;
     }
 
-    if (!aborted || (aborted && !compilerCtx.hasSuccessfulBuild)) {
-      // print out the time it took to build
-      // and add the duration to the build results
-      if (!buildCtx.hasPrintedResults) {
-        buildCtx.timeSpan.finish(`${buildText} ${buildStatus}${watchText}`, statusColor, true, true);
-        buildCtx.hasPrintedResults = true;
-
-        // write the build stats
-        await generateBuildStats(config, compilerCtx, buildCtx, buildCtx.buildResults);
-      }
+    // print out the time it took to build
+    // and add the duration to the build results
+    if (!buildCtx.hasPrintedResults) {
+      buildCtx.timeSpan.finish(`${buildText} ${buildStatus}${watchText}`, statusColor, true, true);
+      buildCtx.hasPrintedResults = true;
 
-      // emit a buildFinish event for anyone who cares
-      compilerCtx.events.emit('buildFinish', buildCtx.buildResults);
+      // write the build stats
+      await generateBuildStats(config, compilerCtx, buildCtx, buildCtx.buildResults);
     }
 
+    // emit a buildFinish event for anyone who cares
+    compilerCtx.events.emit('buildFinish', buildCtx.buildResults);
+
     // write all of our logs to disk if config'd to do so
     // do this even if there are errors or not the active build
     config.logger.writeLogs(buildCtx.isRebuild);

test/sys/node/node-sys.spec.js

@@ -14,6 +14,19 @@ describe('test/sys/node', () => {
   });
 
 
+  it('parse error', () => {
+    const input = {
+      css: `
+        div
+          flex: 1;
+        }
+      `
+    };
+    return sys.optimizeCss(input).then(output => {
+      expect(output.diagnostics).toHaveLength(1);
+    });
+  });
+
   it('autoprefixCss', () => {
     const input = {
       css: `