feat(build): conditionally include svg build features

Author: adamdbradley

src/compiler/build/test/conditionals.spec.ts

@@ -98,14 +98,30 @@ describe('build conditionals', () => {
 
     // kick off a rebuild
     c.trigger('fileAdd', path.join(root, 'src', 'global.css'));
+    await c.fs.writeFile(path.join(root, 'src', 'cmp-a.tsx'), `
+      @Component({ tag: 'cmp-a' }) export class CmpA {
+
+        render() {
+          return [<slot/>];
+        }
+      }
+    `, { clearFileCache: true });
+    await c.fs.commit();
 
     // wait for the rebuild to finish
     // get the rebuild results
     r = await rebuildListener;
     expect(r.diagnostics).toEqual([]);
 
     expect(r.hasSlot).toBe(true);
-    expect(r.hasSvg).toBe(true);
+    expect(r.hasSvg).toBe(false);
+
+    c.trigger('fileAdd', path.join(root, 'src', 'global2.css'));
+    r = await rebuildListener;
+    expect(r.diagnostics).toEqual([]);
+
+    expect(r.hasSlot).toBe(true);
+    expect(r.hasSvg).toBe(false);
   });
 
   it('svg not in build', async () => {

src/renderer/vdom/update-attribute.ts

@@ -6,10 +6,14 @@ export function updateAttribute(
   memberName: string,
   newValue: any,
   isBooleanAttr = typeof newValue === 'boolean',
+  isXlinkNs?: boolean
 ) {
-  const isXlinkNs = (memberName !== (memberName = memberName.replace(/^xlink\:?/, '')));
+  if (__BUILD_CONDITIONALS__.hasSvg) {
+    isXlinkNs = (memberName !== (memberName = memberName.replace(/^xlink\:?/, '')));
+  }
+
   if (newValue == null || (isBooleanAttr && (!newValue || newValue === 'false'))) {
-    if (isXlinkNs) {
+    if (__BUILD_CONDITIONALS__.hasSvg && isXlinkNs) {
       elm.removeAttributeNS(XLINK_NS, toLowerCase(memberName));
 
     } else {
@@ -22,7 +26,7 @@ export function updateAttribute(
     } else {
       newValue = newValue.toString();
     }
-    if (isXlinkNs) {
+    if (__BUILD_CONDITIONALS__.hasSvg && isXlinkNs) {
       elm.setAttributeNS(XLINK_NS, toLowerCase(memberName), newValue);
 
     } else {

src/util/build-conditionals.ts

@@ -145,7 +145,6 @@ export async function setBuildConditionals(
   }
 
   coreBuild.slotPolyfill = true;
-  coreBuild.hasSvg = true;
 
   return coreBuild;
 }

src/util/test/build-conditionals.spec.ts

@@ -90,8 +90,13 @@ describe('build conditionals', () => {
       expect(bc.hasSvg).toBe(true);
     });
 
-    it('set Build.hasSvg always true (for now)', async () => {
-      buildCtx.hasSvg = false;
+    it('default Build.hasSvg false', async () => {
+      const bc = await setBuildConditionals(config, {}, 'core', buildCtx, []);
+      expect(bc.hasSvg).toBe(false);
+    });
+
+    it('set Build.hasSvg true', async () => {
+      buildCtx.hasSvg = true;
       const bc = await setBuildConditionals(config, {}, 'core', buildCtx, []);
       expect(bc.hasSvg).toBe(true);
     });