fix(bundle): handle browser: true correctly

Author: manucorporat

src/compiler/app-core/bundle-app-core.ts

@@ -34,6 +34,7 @@ export async function bundleApp(config: d.Config, compilerCtx: d.CompilerCtx, bu
         stencilBuildConditionalsPlugin(build, config.fsNamespace),
         globalScriptsPlugin(config, compilerCtx),
         componentEntryPlugin(config, compilerCtx, buildCtx, build, buildCtx.entryModules),
+        config.sys.rollup.plugins.emptyJsResolver(),
         config.sys.rollup.plugins.commonjs({
           include: /node_modules/,
           sourceMap: false,
@@ -43,6 +44,7 @@ export async function bundleApp(config: d.Config, compilerCtx: d.CompilerCtx, bu
         pluginHelper(config, compilerCtx, buildCtx),
         config.sys.rollup.plugins.nodeResolve({
           mainFields: ['collection:main', 'jsnext:main', 'es2017', 'es2015', 'module', 'main'],
+          browser: true,
           ...config.nodeResolve
         }),
         bundleJson(config),

src/compiler/component-hydrate/bundle-hydrate-app.ts

@@ -27,6 +27,7 @@ export async function bundleHydrateApp(config: d.Config, compilerCtx: d.Compiler
         stencilBuildConditionalsPlugin(build, config.fsNamespace),
         globalScriptsPlugin(config, compilerCtx),
         componentEntryPlugin(config, compilerCtx, buildCtx, build, buildCtx.entryModules),
+        config.sys.rollup.plugins.emptyJsResolver(),
         config.sys.rollup.plugins.commonjs({
           include: /node_modules/,
           sourceMap: false,

src/sys/node/node-rollup.ts

@@ -11,9 +11,16 @@ export const NodeRollup = {
     nodeResolve,
     replace,
     emptyJsResolver: () => {
+      const emptyFile = path.resolve(__dirname, '../src/empty.js');
       return {
+        resolveId(id: string) {
+          if (id === emptyFile) {
+            return id;
+          }
+          return null;
+        },
         load(id: string) {
-          if (id.endsWith('empty.js') && id.endsWith(path.join(__dirname, '../src/empty.js'))) {
+          if (id === emptyFile) {
             return 'export default {};';
           }
           return null;