perf(): improve runtime for native build (#1549)

Author: manucorporat

src/client/client-host-ref.ts

@@ -11,27 +11,20 @@ export const registerInstance = (lazyInstance: any, hostRef: d.HostRef) =>
   hostRefs.set(hostRef.$lazyInstance$ = lazyInstance, hostRef);
 
 export const registerHost = (elm: d.HostElement) => {
-  // TODO: it's so ugly, but minifies really well
   if (BUILD.lazyLoad) {
-
     const hostRef: d.HostRef = {
       $flags$: 0,
-      $hostElement$: elm
+      $hostElement$: elm,
+      $instanceValues$: new Map()
     };
     hostRef.$onReadyPromise$ = new Promise(r => hostRef.$onReadyResolve$ = r);
-    if (BUILD.prop || BUILD.state) {
-      hostRef.$instanceValues$ = new Map();
-    }
     return hostRefs.set(elm, hostRef);
-
   } else {
-    const hostRef: d.HostRef = {
+
+    return hostRefs.set(elm, {
       $flags$: 0,
-    };
-    if (BUILD.prop || BUILD.state) {
-      hostRef.$instanceValues$ = new Map();
-    }
-    return hostRefs.set(elm, hostRef);
+      $instanceValues$: new Map()
+    });
   }
 };
 

src/client/client-window.ts

@@ -6,6 +6,8 @@ export const win = window;
 
 export const doc = document;
 
+export const H = HTMLElement;
+
 export const plt: d.PlatformRuntime = {
   $flags$: 0,
   $resourcesUrl$: '',
@@ -36,3 +38,5 @@ export const supportsConstructibleStylesheets = BUILD.constructableCSS ? /*@__PU
   } catch (e) {}
   return false;
 })() : false;
+
+export {H as HTMLElement};

src/compiler/app-core/build-conditionals.ts

@@ -31,6 +31,9 @@ export function getBuildFeatures(cmps: d.ComponentCompilerMeta[]) {
     noVdomRender: cmps.every(c => !c.hasVdomRender),
     observeAttribute: cmps.some(c => c.hasAttribute),
     prop: cmps.some(c => c.hasProp),
+    propBoolean: cmps.some(c => c.hasPropBoolean),
+    propNumber: cmps.some(c => c.hasPropNumber),
+    propString: cmps.some(c => c.hasPropString),
     propMutable: cmps.some(c => c.hasPropMutable),
     reflect: cmps.some(c => c.hasReflect),
     scoped: cmps.some(c => c.encapsulation === 'scoped'),

src/compiler/app-core/optimize-module.ts

@@ -83,6 +83,10 @@ export async function optimizeModule(config: d.Config, compilerCtx: d.CompilerCt
 
   const results = await config.sys.minifyJs(input, opts);
   if (results != null && typeof results.output === 'string' && results.diagnostics.length === 0 && compilerCtx != null) {
+    if (isCore) {
+      results.output = results.output
+        .replace(/disconnectedCallback\(\)\{\}/g, '');
+    }
     await compilerCtx.cache.put(cacheKey, results.output);
   }
 

src/compiler/output-targets/output-module.ts

@@ -75,6 +75,7 @@ function getBuildConditionals(config: d.Config, cmps: d.ComponentCompilerMeta[])
   build.hydrateServerSide = false;
 
   updateBuildConditionals(config, build);
+  build.taskQueue = false;
 
   return build;
 }

src/compiler/transformers/collections/parse-collection-deprecated.ts

@@ -77,6 +77,9 @@ function parseComponentDeprecated(config: d.Config, compilerCtx: d.CompilerCtx,
     hasMode: false,
     hasAttribute: false,
     hasProp: false,
+    hasPropNumber: false,
+    hasPropBoolean: false,
+    hasPropString: false,
     hasPropMutable: false,
     hasReflect: false,
     hasRenderFn: false,

src/compiler/transformers/component-build-conditionals.ts

@@ -8,6 +8,9 @@ export function setComponentBuildConditionals(cmpMeta: d.ComponentCompilerMeta)
     cmpMeta.hasPropMutable = cmpMeta.properties.some(p => p.mutable);
     cmpMeta.hasReflect = cmpMeta.properties.some(p => p.reflect);
     cmpMeta.hasAttribute = cmpMeta.properties.some(p => typeof p.attribute === 'string');
+    cmpMeta.hasPropBoolean = cmpMeta.properties.some(p => p.type === 'boolean');
+    cmpMeta.hasPropNumber = cmpMeta.properties.some(p => p.type === 'number');
+    cmpMeta.hasPropString = cmpMeta.properties.some(p => p.type === 'string');
   }
 
   if (cmpMeta.states.length > 0) {

src/compiler/transformers/component-native/native-imports.ts

@@ -9,6 +9,7 @@ export function addNativeImports(transformCtx: ts.TransformationContext, compile
     ...COMMON_IMPORTS,
     `attachShadow as ${ATTACH_SHADOW}`,
     `registerHost as ${REGISTER_HOST}`,
+    `HTMLElement`
   ];
   const moduleFile = getModuleFromSourceFile(compilerCtx, tsSourceFile);
   if (moduleFile && moduleFile.isLegacy) {

src/compiler/transformers/static-to-meta/component.ts

@@ -80,20 +80,23 @@ export function parseStaticComponentMeta(config: d.Config, compilerCtx: d.Compil
     hasMode: false,
     hasAttribute: false,
     hasProp: false,
+    hasPropNumber: false,
+    hasPropBoolean: false,
+    hasPropString: false,
     hasPropMutable: false,
     hasReflect: false,
     hasRenderFn: false,
     hasState: false,
     hasStyle: false,
-    hasVdomAttribute: true,
-    hasVdomClass: true,
-    hasVdomFunctional: true,
-    hasVdomKey: true,
-    hasVdomListener: true,
-    hasVdomRef: true,
+    hasVdomAttribute: false,
+    hasVdomClass: false,
+    hasVdomFunctional: false,
+    hasVdomKey: false,
+    hasVdomListener: false,
+    hasVdomRef: false,
     hasVdomRender: false,
-    hasVdomStyle: true,
-    hasVdomText: true,
+    hasVdomStyle: false,
+    hasVdomText: false,
     hasWatchCallback: false,
     isPlain: false,
     htmlAttrNames: [],

src/declarations/build-conditionals.ts

@@ -51,6 +51,9 @@ export interface BuildFeatures {
   watchCallback: boolean;
   member: boolean;
   updatable: boolean;
+  propBoolean: boolean;
+  propNumber: boolean;
+  propString: boolean;
 
   // lifecycle events
   lifecycle: boolean;