Skip to content

Commit 9dbb88f

Browse files
vidarcmanucorporat
authored andcommitted
fix(): fixing unsafe usage of target="_blank" (#1604)
1 parent 1eeb780 commit 9dbb88f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/compiler/app-core/app-es5-disabled.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ h2 {
4040
<h2>Developers:</h2>
4141
<ul>
4242
<li>ES5 builds are disabled <strong>during development</strong> to take advantage of 2x faster build times.</li>
43-
<li>Please see the example below or our <a href="https://stenciljs.com/docs/stencil-config" target="_blank">config docs</a> if you would like to develop on a browser that does not fully support ES2017 and custom elements.</li>
43+
<li>Please see the example below or our <a href="https://stenciljs.com/docs/stencil-config" target="_blank" rel="noopener noreferrer">config docs</a> if you would like to develop on a browser that does not fully support ES2017 and custom elements.</li>
4444
<li>Note that by default, ES5 builds and polyfills are enabled during production builds.</li>
4545
<li>When testing browsers it is recommended to always test in production mode, and ES5 builds should always be enabled during production builds.</li>
4646
<li><em>This is only an experiement and if it slows down app development then we will revert this and enable ES5 builds during dev.</em></li>
@@ -98,7 +98,7 @@ h2 {
9898
<h2 style="margin-top:0">AFTER:</h2>
9999
<p>The index.html should now include two scripts using the modern ES Module script pattern.
100100
Note that only one file will actually be requested and loaded based on the browser's native support for ES Modules.
101-
For more info, please see <a href="https://developers.google.com/web/fundamentals/primers/modules#browser" target="_blank">Using JavaScript modules on the web</a>.
101+
For more info, please see <a href="https://developers.google.com/web/fundamentals/primers/modules#browser" target="_blank" rel="noopener noreferrer">Using JavaScript modules on the web</a>.
102102
</p>
103103
<pre>
104104
<code>${escapeHtml(`<script`)} <span style="background:yellow">type="module"</span> src="/build/${config.fsNamespace}<span style="background:yellow">.esm</span>.js"${escapeHtml(`></script>`)}

0 commit comments

Comments
 (0)