fix(): dont error about exported function in global

Author: manucorporat

src/compiler/app-core/bundle-app-core.ts

@@ -38,7 +38,7 @@ export const bundleApp = async (config: d.Config, compilerCtx: d.CompilerCtx, bu
         }),
         stencilClientPlugin(config),
         stencilBuildConditionalsPlugin(build, config.fsNamespace),
-        globalScriptsPlugin(config, compilerCtx, buildCtx),
+        globalScriptsPlugin(config, compilerCtx),
         componentEntryPlugin(config, compilerCtx, buildCtx, build, buildCtx.entryModules),
         config.sys.rollup.plugins.commonjs({
           include: /node_modules/,

src/compiler/component-hydrate/bundle-hydrate-app.ts

@@ -30,7 +30,7 @@ export const bundleHydrateApp = async (config: d.Config, compilerCtx: d.Compiler
         }),
         stencilHydratePlugin(config),
         stencilBuildConditionalsPlugin(build, config.fsNamespace),
-        globalScriptsPlugin(config, compilerCtx, buildCtx),
+        globalScriptsPlugin(config, compilerCtx),
         componentEntryPlugin(config, compilerCtx, buildCtx, build, buildCtx.entryModules),
         config.sys.rollup.plugins.commonjs({
           include: /node_modules/,

src/compiler/rollup-plugins/component-entry.ts

@@ -17,7 +17,6 @@ export const componentEntryPlugin = (config: d.Config, compilerCtx: d.CompilerCt
           entrys.set(id, entryModule);
           return {
             id,
-            moduleSideEffects: false
           };
         }
       }

src/compiler/rollup-plugins/global-scripts.ts

@@ -1,5 +1,5 @@
 import * as d from '../../declarations';
-import { buildError, normalizePath } from '@utils';
+import { normalizePath } from '@utils';
 import { Plugin } from 'rollup';
 
 
@@ -17,7 +17,7 @@ export function hasGlobalScriptPaths(config: d.Config, compilerCtx: d.CompilerCt
 }
 
 
-export function globalScriptsPlugin(config: d.Config, compilerCtx: d.CompilerCtx, buildCtx: d.BuildCtx): Plugin {
+export function globalScriptsPlugin(config: d.Config, compilerCtx: d.CompilerCtx): Plugin {
   const globalPaths: string[] = [];
 
   if (typeof config.globalScript === 'string') {
@@ -39,7 +39,6 @@ export function globalScriptsPlugin(config: d.Config, compilerCtx: d.CompilerCtx
       if (id === GLOBAL_ID) {
         return {
           id,
-          moduleSideEffects: true
         };
       }
       return null;
@@ -62,27 +61,12 @@ export function globalScriptsPlugin(config: d.Config, compilerCtx: d.CompilerCtx
     transform(code, id) {
       id = normalizePath(id);
       if (globalPaths.includes(id)) {
-        const output = [
-          INJECT_CONTEXT
-        ];
-
         const program = this.parse(code, {});
         const needsDefault = !program.body.some(s => s.type === 'ExportDefaultDeclaration');
-
-        if (needsDefault) {
-          const diagnostic = buildError(buildCtx.diagnostics);
-          diagnostic.header = `Global Script`;
-          diagnostic.absFilePath = id;
-          diagnostic.messageText = `The code to be executed should be placed within a default function that is exported by the global script. Ensure all of the code in the global script is wrapped in the function() that is exported.`;
-
-          output.push(`export const fallbackGlobalFn = () => {}`);
-          output.push(`export default fallbackGlobalFn;`);
-
-        } else {
-          output.push(code);
-        }
-
-        return output.join('\n');
+        const defaultExport = needsDefault
+          ? '\nexport const globalFn = () => {};\nexport default globalFn;'
+          : '';
+        return INJECT_CONTEXT + code + defaultExport;
       }
       return null;
     }

src/compiler/rollup-plugins/loader.ts

@@ -8,7 +8,6 @@ export function loaderPlugin(entries: {[id: string]: string}): Plugin {
       if (id in entries) {
         return {
           id,
-          moduleSideEffects: false
         };
       }
       return null;

src/compiler/rollup-plugins/stencil-build-conditionals.ts

@@ -12,7 +12,6 @@ export const NAMESPACE = '${namespace}';
       if (id === '@stencil/core/build-conditionals') {
         return {
           id,
-          moduleSideEffects: false
         };
       }
       return null;

src/compiler/rollup-plugins/stencil-client.ts

@@ -9,7 +9,6 @@ export function stencilClientPlugin(config: d.Config): Plugin {
       if (id === '@stencil/core/platform') {
         return {
           id: config.sys.path.join(config.sys.compiler.distDir, 'client', 'index.mjs'),
-          moduleSideEffects: false
         };
       }
       return null;

src/compiler/rollup-plugins/stencil-hydrate.ts

@@ -9,25 +9,21 @@ export function stencilHydratePlugin(config: d.Config): Plugin {
       if (id === '@stencil/core/platform') {
         return {
           id: config.sys.path.join(config.sys.compiler.distDir, 'hydrate', 'platform.mjs'),
-          moduleSideEffects: false
         };
       }
       if (id === '@stencil/core/runtime') {
         return {
           id: config.sys.path.join(config.sys.compiler.distDir, 'runtime', 'index.mjs'),
-          moduleSideEffects: false
         };
       }
       if (id === '@stencil/core/utils') {
         return {
           id: config.sys.path.join(config.sys.compiler.distDir, 'utils', 'index.mjs'),
-          moduleSideEffects: false
         };
       }
       if (id === '@stencil/core') {
         return {
           id: config.sys.path.join(config.sys.compiler.distDir, 'hydrate', 'platform.mjs'),
-          moduleSideEffects: false
         };
       }
       return null;