-
Notifications
You must be signed in to change notification settings - Fork 0
[ION-281] use ionic SDK in langchain tool #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
this adds a numpy upgrade which supports python 3.12
|
|
||
|
|
||
|
|
||
| class IonicPluginTool(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@owensims1 is this still relevant? I see it commented out in the demobot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's gonna be two ways to integrate a langchsin tool-- first is using the sdk which is how i had been using since the beginning.
this is the second, where after we built the openai plugin route, we noticed that langchsin has an integration solution for this, but i found it to not work anywhere near as well as advertised, and i lost interest in pursuing at the time.
so, feel free to remove entirely for now until we can bring it back in an official capacity. let's stick with the sdk connection that affords us a bit more control
currently the server has a bug where this must be specified. fixed in https://github.com/ioniccommerce/server/pull/179
given we deleted stuff I think minor makes more sense than patch
|
@owensims1 this is working locally; PTAL and we can chat in our 1:1 about what to tidy it up to make it mergeable |
owensims1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. good start. will want to get error handling in and we can also start hammering it from a usability standpoint tomorrow
This reverts commit 12e8cb1.

verification
running demobot UI locally with the agent pointing to this git branch:
https://app.datadoghq.com/logs?query=%40otelTraceID%3A57989f513240e8d5b21d2990c915a535%20&cols=host%2Cservice&index=%2A&messageDisplay=inline&refresh_mode=sliding&stream_sort=desc&viz=stream&from_ts=1702941286425&to_ts=1702942186425&live=true