Skip to content

Conversation

@gmkohler
Copy link
Contributor

@gmkohler gmkohler commented Dec 18, 2023

@linear
Copy link

linear bot commented Dec 18, 2023




class IonicPluginTool():
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@owensims1 is this still relevant? I see it commented out in the demobot

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's gonna be two ways to integrate a langchsin tool-- first is using the sdk which is how i had been using since the beginning.

this is the second, where after we built the openai plugin route, we noticed that langchsin has an integration solution for this, but i found it to not work anywhere near as well as advertised, and i lost interest in pursuing at the time.

so, feel free to remove entirely for now until we can bring it back in an official capacity. let's stick with the sdk connection that affords us a bit more control

Gregory Kohler added 2 commits December 18, 2023 15:25
currently the server has a bug where this must be specified.
fixed in https://github.com/ioniccommerce/server/pull/179
given we deleted stuff I think minor makes more sense than patch
@gmkohler gmkohler requested a review from owensims1 December 18, 2023 23:33
@gmkohler
Copy link
Contributor Author

@owensims1 this is working locally; PTAL and we can chat in our 1:1 about what to tidy it up to make it mergeable

@gmkohler gmkohler marked this pull request as ready for review December 18, 2023 23:34
Copy link
Contributor

@owensims1 owensims1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. good start. will want to get error handling in and we can also start hammering it from a usability standpoint tomorrow

Gregory Kohler added 2 commits December 19, 2023 10:43
@gmkohler
Copy link
Contributor Author

Verified this is working with SDK after teh revert commit (37e3b28) and deploying server v0.2.3

Screenshot 2023-12-19 at 10 57 46

@gmkohler gmkohler merged commit af38117 into main Dec 19, 2023
@gmkohler gmkohler deleted the gmkohler/ION-281 branch December 19, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants