📦 upgrade SDK to 0.5.3 #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmkohler
force-pushed
the
gmkohler/tests
branch
from
0f98fdd to
a23ab93
Compare
gmkohler
commented
Dec 21, 2023
| ) | ||
|
|
||
| return dataclasses.asdict(response) | ||
| return [dataclasses.asdict(r) for r in response.query_api_response.results] |
Contributor
Author
There was a problem hiding this comment.
I thought this would be more useful than the entire response
gmkohler
commented
Dec 21, 2023
|
|
||
| def __init__(self): | ||
| self._sdk = IonicSDK() | ||
| def __init__(self, sdk: Optional[IonicSDK] = None): |
Contributor
Author
There was a problem hiding this comment.
injecting the SDK facilitates testing (and any other customization that may be desired by our users down the road)
stewartjarod
approved these changes
Dec 21, 2023
stewartjarod
added a commit
that referenced
this pull request
Jan 18, 2024
* 📦 upgrade SDK to 0.5.3 (#3) * tests * 📦 update ionic-sdk-python * 🏷️ bump version * inject ionic into tool (#4) * let ionic be injected into tool * 🏷️ bump version * 📖 [ION-283] document langchain tool (#5) * 📦 fleixble langchain dependency; pinned sdk Idea here being we control which SDK version is being used but allow developers to have higher patch versions of langchain. https://python-poetry.org/docs/dependency-specification/#tilde-requirements * 📖 first pass at documentation * Update README.md * 👷♂️📦🏷️ [ION-285] workflow for publishing new releases (#7) * 👷♂️📦 workflow for publishing new releases Right now this requires manually bumping poetry and creating a git release but I added a couple of guardrails so that we ensure we only publish when the poetry package version matches the github release reference. Future iteration will move the version bumping and release cutting to the workflow. * 🏷️ bump verison to 0.1.3 want something to test with when this merges * set workflow up for iterative testing * dry run for publishing * warn instead of fail if tag checks fail * 👷♂️ [ION-285] release publication workflow fixups (#8) * 📌 pin python version * 🐛 use ref_name instead of ref ref is a lot longer, e.g. 'refs/heads/gmkohler/ION-285' found with debug logging * 🏷️ bump patch version want to compare with new release * 👷♂️ [ION-285] Revert "set workflow up for iterative testing" (#10) * Revert "set workflow up for iterative testing" This reverts commit 49cc39f. * 🏷️ bump version to 0.1.5 want to test the release guardrails * 👷♂️ [ION-285] adjust github expressions (#11) * tidy expressions up think it all needs to be interpolated * 🏷️ poetry version patch need to verify new changes * 👷♂️ [ION-285] automate version bumping / tagging in release workflow (#9) * 👷♂️ bump version within workflow * ☑️ use type: choice for release input This should enforce a dropdown * fix release-action name * tidy release step * 🏷️ prepare version v0.1.7 for release * 🏷️ prepare version v0.1.8 for release * 📖 add sentence re: python version support (#12) * 📖 install library from PyPI instead of GitHub (#13) * Reduce min python version (#14) * version * readme * whoops * working example (#15) --------- Co-authored-by: Gregory M Kohler <gregory@ionicapi.com> Co-authored-by: gmkohler <gmkohler@users.noreply.github.com> Co-authored-by: Owen Sims <owen@ionicapi.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I loaded this branch into our demobot and I am getting results