Chop off checksum when using address in core commands

[todofixthis]

Example:

In [1]: from iota import Address

In [2]: addy = Address('WLVZXWARPSYCWJMBZJGXHUOVYBVCEKMNQDMXHCAEJZFLFLMHFYYQQSSLVYWAZWESKXZOROLU9OQFRVDEWCHKKXPWGY')

In [3]: api.get_balances([addy])
iota.adapter.BadApiResponse: 400 response from node: Invalid addresses input

Workaround:

In [4]: api.get_balances([addy.address])
Out[4]:
{'balances': [0],
 'duration': 9,
 'milestone': Address(b'GNKYBMEKZFBYEQXINYTUGLGVSYCMRBBYDCWJ9KMJUTVMNDUVZQKGJK9RPBGTLWPYYERSLBPQBUTRZ9999'),
 'milestoneIndex': 286176}

I feel like PyOTA should do this automatically — there are a lot of use cases that involve generating addresses with checksums; it would get pretty unwieldy to have to remember to extract just the address when calling certain commands.

[plenarius]

Gonna look into tackling this over the next week.

[plenarius]

Okay, the only two core commands that take addresses as arguments are get_balances and find_transactions. My first shot at this has me massaging the addresses in a new _prepare_requests for both GetBalancesCommand and FindTransactionsCommand with such:

def _prepare_request(self, request):
    no_checksum_addresses = []

    for addy in request['addresses']:
      no_checksum_addresses.append(Address(addy).address)

    request['addresses'] = no_checksum_addresses

    return self._apply_filter(
      value           = request,
      filter_         = self.get_request_filter(),
      failure_message = 'Request failed validation',
    )

Sound like an okay approach?

[todofixthis]

Could we integrate this functionality directly into the filters? That way, we don't have to worry about copy-pasting that code if we add new commands in the future (I'm aware of at least 2 that are coming in the next IRI release).

Also, moving that functionality into filters ensures that the code automatically catches problems with wrong type/format before it tries to extract the address value.

Take a look at these guys and see if it makes sense to implement a filter and/or extend the Trytes filter to achieve this functionality:
https://github.com/iotaledger/iota.lib.py/blob/develop/iota/filters.py
https://filters.readthedocs.io/en/latest/writing_filters.html#custom-filters

[plenarius]

Yep I can certainly do that, looked all into that already but thought it may be overkill. Will see what I come up with.

[todofixthis]

Scheduled for release: 2.0.3