This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Clarify Address usage in send example #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved the script to explain the recipient address a little better. Changed the address concat to a reference to a specific kind of Iota address. This is loosely inspired by the JAVA sen transaction test case.
Contributor
Author
|
Example improvement due to overlooking the fact that the recipient address was shown as a two line (concat) address. Included a different way to show the fact that the address is security level 2 with validation. |
Contributor
Author
|
Reopened due to incorrect close |
Contributor
|
Hey @maeck70 thank you for your pull request! I will take a look later this week. |
todofixthis
approved these changes
Jan 16, 2018
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Looks good, thanks @maeck70! Let's merge this and see what the community thinks (:
marko-k0
pushed a commit
to marko-k0/iota.lib.py
that referenced
this pull request
Jul 28, 2018
Clarify Address usage in send example
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the script to explain the recipient address a little better.
Changed the address concat to a reference to a specific kind of Iota address.
This is loosely inspired by the JAVA sen transaction test case.