Skip to content
This repository was archived by the owner on Jan 13, 2023. It is now read-only.

Conversation

@Hribek25
Copy link
Contributor

@Hribek25 Hribek25 commented Jul 4, 2018

fixes #191

@todofixthis
Copy link
Contributor

Hey @Hribek25 thanks for working on this!

Looks like there is one test failing; could you have a look at the Travis CI build result?

Once that's addressed, this should be ready to merge 😺

@Hribek25
Copy link
Contributor Author

Hribek25 commented Jul 5, 2018

Hey @todofixthis , thanks for your guidance.

While changing depth=100 -> depth=3 I was changing it also in test routines and it turned out to not be best idea:) Changes to test routines were reverted back.

@todofixthis todofixthis changed the base branch from master to develop July 6, 2018 21:01
@todofixthis
Copy link
Contributor

Looks good. I feel like we should set a default value for depth in the routines as well, but maybe we'll make that a separate issue, since it currently doesn't have a default value.

I just changed the target branch to develop, which introduced a couple of conflicts (we're currently in the middle of PEP-8-ifying the codebase). Once those conflicts are resolved, this PR is ready to merge 😺

@todofixthis todofixthis changed the title fixes #191 Change depth to 3 in examples Jul 10, 2018
@todofixthis
Copy link
Contributor

Cheers for that! I will give it a final once-over this weekend 😺

@todofixthis
Copy link
Contributor

Looks good. Thanks @Hribek25 !

@todofixthis todofixthis merged commit 2baf06b into iotaledger-archive:develop Jul 16, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this pull request Jul 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants