This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Refactored repeated filter logic into macro. #243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzpap
added a commit
to lzpap/pyota
that referenced
this pull request
Oct 10, 2019
StringifiedTrytesArray(Type) filter macro was introduced in iotaledger-archive#243. Becasue of this, no request filter test case is needed, hence the macro is covered already in other test cases.
lzpap
added a commit
to lzpap/pyota
that referenced
this pull request
Oct 10, 2019
StringifiedTrytesArray(Type) filter macro was introduced in iotaledger-archive#243. Becasue of this, no request filter test case is needed, hence the macro is covered already in other test cases.
lzpap
added a commit
to lzpap/pyota
that referenced
this pull request
Oct 10, 2019
StringifiedTrytesArray(Type) filter macro was introduced in iotaledger-archive#243. Becasue of this, no request filter test case is needed, hence the macro is covered already in other test cases.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts copy-pasted filter logic into a new filter macro. In particular, this reduces unit testing burden for new command request filters — we have plenty of coverage for the new
StringifiedTrytesArrayfilter macro, so it shouldn't be necessary to write additional tests if a new command wants to use it.See #242 (comment) for context.