This repository was archived by the owner on Jan 13, 2023. It is now read-only.
add_signature_or_message method for ProposedBundle #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
suggested changes
Nov 6, 2019
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Recommending that this method not be callable after the bundle is finalised. Otherwise looks good w/ suggestions+questions.
todofixthis
suggested changes
Nov 6, 2019
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Recommending that this method not be callable after the bundle is finalised. Otherwise looks good w/ suggestions+questions.
lzpap
force-pushed
the
add_signature_or_message
branch
from
d8843bf to
28f0586
Compare
Collaborator
Author
|
Thanks for the review @todofixthis, I implemented your suggested changes. |
todofixthis
approved these changes
Nov 14, 2019
The method can insert custom messages or signatures into transactions in a ProposedBundle object. Must be called before bundle is finalized.
lzpap
force-pushed
the
add_signature_or_message
branch
from
28f0586 to
22b4f46
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #253
Description
The method can insert custom messages or signatures into transactions in a
ProposedBundleobject.Motivation
Ability to easily add custom messages to transactions after
ProposedBundlecreation.Additional Info
The test file is formatted with 2 space indentation to make review easier. In a future PR old test files will be converted to use 4 space indentation as per PEP-8.