This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Support adding/removing address checksums #265
Merged
+97
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
approved these changes
Nov 16, 2019
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Recommend adding two more tests; otherwise LGTM
Two new methods in Address class: - add_checksum: appends a valid checksum to the Address object. - remove_checksum: slices off the checksum from an Address object.
lzpap
force-pushed
the
address_methods
branch
from
6b544b4 to
d6453e5
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #254
Changes
Two new methods in
Addressclass:add_checksum: Appends a valid checksum to theAddressobject.Address.checksumattribute is updated and checksum trytes are appended to internal tryte buffer.remove_checksum: Slices off the checksum from anAddressobject.Address.checksumattribute is updated (to valueNone) and internal tryte buffer is modified to hold only the 81 original address trytes.