This repository was archived by the owner on Jan 13, 2023. It is now read-only.
Add wereAddressesSpentFrom check to used/new address discovery
#271
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
approved these changes
Dec 2, 2019
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
LGTM w/ minor questions/suggestions.
Comment on lines
+950
to
+951
| # ``getInputs`` uses ``findTransactions`` and | ||
| # ``wereAddressesSpentFrom`` to identify unused addresses. |
Contributor
There was a problem hiding this comment.
❔ We didn't modify get_inputs.py in this PR — is this comment accurate?
Collaborator
Author
There was a problem hiding this comment.
get_inputs uses iter_used_addresses, which was modified according to this comment.
…new_addresses` So far only `findTransactions` check was made in the the two methods above, this changes is needed to achieve identical behavior with the JS lib. Based on @pdecol's implementation.
lzpap
force-pushed
the
pdecol_snapshot_pr_cleaned
branch
from
2073d3f to
3395a41
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains parts of #244
Details
So far only
findTransactionscheck was made initer_used_addressesandget_new_addresses.With these changes, a used address becomes:
A new address becomes:
These changes are needed to achieve identical behavior with the JS lib.
Huge thanks to @pdecol, who did the initial implementation and pull request!