This repository was archived by the owner on Jan 13, 2023. It is now read-only.
get_bundles can return multiple bundles
#293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
todofixthis
suggested changes
Jan 23, 2020
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Strongly recommend changing GetBundlesRequestFilter and adding corresponding test; otherwise looks good with minor questions/suggestions.
lzpap
commented
Jan 24, 2020
Collaborator
Author
lzpap
left a comment
lzpap
left a comment
There was a problem hiding this comment.
Thx for the review @todofixthis !
lzpap
force-pushed
the
multiple_bundles
branch
from
70f4723 to
db59ed0
Compare
todofixthis
approved these changes
Jan 25, 2020
Contributor
todofixthis
left a comment
todofixthis
left a comment
There was a problem hiding this comment.
Thanks for making those changes! Looks good (with one minor suggestion 😁)!
- accept a list of tail transaction hashes instead of just one. - return multiple bundles in the same order as the input tail hashes - added test coverage - modified calls to GetBundlesCommand() in the lib WARNING: Breaking change!
lzpap
force-pushed
the
multiple_bundles
branch
from
db59ed0 to
82a0f24
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves: #250
Changes
get_bundlesextended API call accepts a list of tail transaction hashes instead of just one.get_bundlesreturns multiple bundles in the same order as the input tail hashes.GetBundlesCommand()throughout the lib.WARNING: Breaking change!